pgsql: libpqwalreceiver: Convert to libpq-be-fe-helpers.h

From: Andres Freund <andres(at)anarazel(dot)de>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: libpqwalreceiver: Convert to libpq-be-fe-helpers.h
Date: 2023-01-24 03:27:10
Message-ID: E1pK9xm-005Awo-He@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

libpqwalreceiver: Convert to libpq-be-fe-helpers.h

In contrast to the changes to dblink and postgres_fdw, this does not fix a
bug, as libpqwalreceiver did already process interrupts.

Besides reducing code duplication, the conversion leads to libpqwalreceiver
now using reserving file descriptors for libpq connections. While not strictly
required for the use in walreceiver, we are also using libpqwalreceiver for
logical replication, where it does seem more important.

Even if we eventually decide to backpatch the prior commits, there'd be no
need to backpatch this commit, due to not fixing an active bug.

Reviewed-by: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>
Discussion: https://postgr.es/m/20220925232237.p6uskba2dw6fnwj2@awork3.anarazel.de

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/728f86fec65537eade8d9e751961782ddb527934

Modified Files
--------------
.../libpqwalreceiver/libpqwalreceiver.c | 53 +++-------------------
1 file changed, 7 insertions(+), 46 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Amit Kapila 2023-01-24 04:09:52 pgsql: Fix the Drop Database hang.
Previous Message Andres Freund 2023-01-24 02:51:00 pgsql: Fix error handling in libpqrcv_connect()