pgsql: Fix and clarify function comment on LogicalTapeSetCreate.

From: Heikki Linnakangas <heikki(dot)linnakangas(at)iki(dot)fi>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Fix and clarify function comment on LogicalTapeSetCreate.
Date: 2023-01-23 09:59:42
Message-ID: E1pJtc5-00535n-QE@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Fix and clarify function comment on LogicalTapeSetCreate.

Commit c4649cce39 removed the "shared" and "ntapes" arguments, but the
comment still talked about "shared". It also talked about "a shared
file handle", which was technically correct because even before commit
c4649cce39, the "shared file handle" referred to the "fileset"
argument, not "shared". But it was very confusing. Improve the
comment.

Also add a comment on what the "preallocate" argument does.

Backpatch to v15, just to make backpatching other patches easier in
the future.

Discussion: https://www.postgresql.org/message-id/af989685-91d5-aad4-8f60-1d066b5ec309@enterprisedb.com
Reviewed-by: Peter Eisentraut

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/236f1ea84c4ca6a29d790fac4b48eba12a74443c

Modified Files
--------------
src/backend/utils/sort/logtape.c | 14 ++++++++++----
1 file changed, 10 insertions(+), 4 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message David Rowley 2023-01-23 10:08:59 pgsql: Run pgindent on heapam.c
Previous Message David Rowley 2023-01-23 08:32:11 pgsql: Harden new parallel string_agg/array_agg regression test