pgsql: Fix jsonpath existense checking of missing variables

From: Alexander Korotkov <akorotkov(at)postgresql(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Fix jsonpath existense checking of missing variables
Date: 2023-01-12 15:30:06
Message-ID: E1pFzWn-003J4J-No@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Fix jsonpath existense checking of missing variables

The current jsonpath code assumes that the referenced variable always exists.
It could only throw an error at the value valuation time. At the same time
existence checking assumes variable is present without valuation, and error
suppression doesn't work for missing variables.

This commit makes existense checking trigger an error for missing variables.
This makes the overall behavior consistent.

Backpatch to 12 where jsonpath was introduced.

Reported-by: David G. Johnston
Discussion: https://postgr.es/m/CAKFQuwbeytffJkVnEqDyLZ%3DrQsznoTh1OgDoOF3VmOMkxcTMjA%40mail.gmail.com
Author: Alexander Korotkov, David G. Johnston
Backpatch-through: 12

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/3161ae86ce3ced0a91c2d3cdbbdc602d6e19892d

Modified Files
--------------
src/backend/utils/adt/jsonpath_exec.c | 8 +++++--
src/test/regress/expected/jsonb_jsonpath.out | 32 ++++++++++++++++++++++++++++
src/test/regress/sql/jsonb_jsonpath.sql | 8 +++++++
3 files changed, 46 insertions(+), 2 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2023-01-12 20:44:29 Re: pgsql: Improve handling of inherited GENERATED expressions.
Previous Message Alexander Korotkov 2023-01-12 15:26:35 pgsql: Fix jsonpath existense checking of missing variables