pgsql: Constify the arguments of ilist.c/h functions

From: Peter Eisentraut <peter(at)eisentraut(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Constify the arguments of ilist.c/h functions
Date: 2023-01-12 07:14:51
Message-ID: E1pFrnW-003FOL-QB@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Constify the arguments of ilist.c/h functions

Const qualifiers ensure that we don't do something stupid in the
function implementation. Additionally they clarify the interface. As
an example:

void
slist_delete(slist_head *head, const slist_node *node)

Here one can instantly tell that node->next is not going to be set to
NULL. Finally, const qualifiers potentially allow the compiler to do
more optimizations. This being said, no benchmarking was done for
this patch.

The functions that return non-const pointers like slist_next_node(),
dclist_next_node() etc. are not affected by the patch intentionally.

Author: Aleksander Alekseev
Reviewed-by: Andres Freund
Discussion: https://postgr.es/m/CAJ7c6TM2%3D08mNKD9aJg8vEY9hd%2BG4L7%2BNvh30UiNT3kShgRgNg%40mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/c8ad4d8166aabd6ed5124e7e432166637d0fe646

Modified Files
--------------
src/backend/lib/ilist.c | 8 ++++----
src/include/lib/ilist.h | 26 +++++++++++++-------------
2 files changed, 17 insertions(+), 17 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Andrew Dunstan 2023-01-12 10:52:00 Re: pgsql: Improve handling of inherited GENERATED expressions.
Previous Message Peter Eisentraut 2023-01-12 06:47:54 pgsql: Code cleanup