pgsql: Sample postgres_fdw tables remotely during ANALYZE

From: Tomas Vondra <tomas(dot)vondra(at)postgresql(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Sample postgres_fdw tables remotely during ANALYZE
Date: 2022-12-30 22:31:51
Message-ID: E1pBNuo-001DDN-O2@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Sample postgres_fdw tables remotely during ANALYZE

When collecting ANALYZE sample on foreign tables, postgres_fdw fetched
all rows and performed the sampling locally. For large tables this means
transferring and immediately discarding large amounts of data.

This commit allows the sampling to be performed on the remote server,
transferring only the much smaller sample. The sampling is performed
using the built-in TABLESAMPLE methods (system, bernoulli) or random()
function, depending on the remote server version.

Remote sampling can be enabled by analyze_sampling on the foreign server
and/or foreign table, with supported values 'off', 'auto', 'system',
'bernoulli' and 'random'. The default value is 'auto' which uses either
'bernoulli' (TABLESAMPLE method) or 'random' (for remote servers without
TABLESAMPLE support).

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/8ad51b5f446b5c19ba2c0033a0f7b3180b3b6d95

Modified Files
--------------
contrib/postgres_fdw/deparse.c | 72 ++++++++-
contrib/postgres_fdw/expected/postgres_fdw.out | 25 +++
contrib/postgres_fdw/option.c | 21 +++
contrib/postgres_fdw/postgres_fdw.c | 202 ++++++++++++++++++++++++-
contrib/postgres_fdw/postgres_fdw.h | 15 ++
contrib/postgres_fdw/sql/postgres_fdw.sql | 36 +++++
doc/src/sgml/postgres-fdw.sgml | 35 +++++
7 files changed, 397 insertions(+), 9 deletions(-)

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Thomas Munro 2022-12-31 21:46:32 pgsql: ci: Change macOS builds from Intel to ARM.
Previous Message Tomas Vondra 2022-12-30 19:50:12 pgsql: Fix assert in BRIN build_distances