From: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
---|---|
To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | pgsql: Change argument of appendBinaryStringInfo from char * to void * |
Date: | 2022-12-30 10:15:36 |
Message-ID: | E1pBCQK-00181T-He@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Change argument of appendBinaryStringInfo from char * to void *
There is some code that uses this function to assemble some kind of
packed binary layout, which requires a bunch of casts because of this.
Functions taking binary data plus length should take void * instead,
like memcpy() for example.
Discussion: https://www.postgresql.org/message-id/flat/a0086cfc-ff0f-2827-20fe-52b591d2666c%40enterprisedb.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/1f605b82ba66ece8b421b10d41094dd2e3c0c48b
Modified Files
--------------
src/backend/utils/adt/jsonpath.c | 18 +++++++++---------
src/backend/utils/adt/xid8funcs.c | 4 ++--
src/common/stringinfo.c | 4 ++--
src/include/lib/stringinfo.h | 4 ++--
4 files changed, 15 insertions(+), 15 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Michael Paquier | 2022-12-30 11:49:06 | pgsql: Fix precision handling for some COERCE_SQL_SYNTAX functions |
Previous Message | Peter Eisentraut | 2022-12-30 09:16:02 | pgsql: Remove unnecessary casts |