pgsql: Simplify the implementations of the to_reg* functions.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Simplify the implementations of the to_reg* functions.
Date: 2022-12-27 17:33:10
Message-ID: E1pADp8-000h6b-7L@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Simplify the implementations of the to_reg* functions.

Given the soft-input-error feature, we can reduce these functions
to be just thin wrappers around a soft-error call of the
corresponding datatype input function. This means less code and
more certainty that the to_reg* functions match the normal input
behavior.

Notably, it also means that they will accept numeric OID input,
which they didn't before. It's not clear to me if that omission
had more than laziness behind it, but it doesn't seem like
something we need to work hard to preserve.

Discussion: https://postgr.es/m/3910031.1672095600@sss.pgh.pa.us

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/3ea7329c9a79ade27b5d3742d1a41ce6d0d9aca8

Modified Files
--------------
doc/src/sgml/func.sgml | 27 ++----
src/backend/utils/adt/regproc.c | 195 +++++++++++-----------------------------
2 files changed, 63 insertions(+), 159 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2022-12-27 18:06:52 pgsql: Remove new locale dependency in regproc regression test.
Previous Message Tom Lane 2022-12-27 17:00:49 pgsql: Convert tsqueryin and tsvectorin to report errors softly.