pgsql: Fix some incorrectness in upgrade_adapt.sql on query for WITH OI

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Fix some incorrectness in upgrade_adapt.sql on query for WITH OI
Date: 2022-12-23 02:28:17
Message-ID: E1p8XnE-004y5A-RV@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Fix some incorrectness in upgrade_adapt.sql on query for WITH OIDS

The query used to disable WITH OIDS in all the relations making use of
it was checking for materialized views, but this is not a supported
operation. On the contrary, this needs to be done on foreign tables.

While on it, use quote_ident() in the ALTER TABLE strings built on the
relation name.

Author: Anton A. Melnikov, Michael Paquier
Discussion: https://postgr.es/m/49f389ba-95ce-8a9b-09ae-f60650c0e7c7@inbox.ru
Backpatch-through: 12

Branch
------
REL_13_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/d4fea2e89d44a0132e86a1659cf79e8c3057bb57

Modified Files
--------------
src/bin/pg_upgrade/upgrade_adapt.sql | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Michael Paquier 2022-12-23 02:37:21 pgsql: Update upgrade_adapt.sql to handle tables using aclitem as data
Previous Message Michael Paquier 2022-12-23 01:05:49 Re: pgsql: Remove dead code