From: | Michael Paquier <michael(at)paquier(dot)xyz> |
---|---|
To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | pgsql: Add LSN location in some error messages related to WAL pages |
Date: | 2022-12-05 00:29:31 |
Message-ID: | E1p1zMQ-00221j-3N@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Add LSN location in some error messages related to WAL pages
The error messages reported during any failures while reading or
validating the header of a WAL currently includes only the offset of the
page but not the compiled LSN referring to the page, requiring an extra
step to compile it if looking at the surroundings with pg_waldump or
similar. Adding this information costs a bit in translation, but also
eases debugging.
Author: Bharath Rupireddy
Reviewed-by: Álvaro Herrera, Kyotaro Horiguchi, Maxim Orlov, Michael
Paquier
Discussion: https://postgr.es/m/CALj2ACWV=FCddsxcGbVOA=cvPyMr75YCFbSQT6g4KDj=gcJK4g@mail.gmail.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/71cb84ec69a38444c48bd8d3b5451b2da157848b
Modified Files
--------------
src/backend/access/transam/xlogreader.c | 15 ++++++++++-----
src/backend/access/transam/xlogrecovery.c | 13 ++++++++-----
2 files changed, 18 insertions(+), 10 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Michael Paquier | 2022-12-05 02:24:13 | pgsql: doc: Add missing <varlistentry> markups for developer GUCs |
Previous Message | David Rowley | 2022-12-04 22:57:07 | pgsql: Fix thinko introduced in 6b423ec67 |