pgsql: Generalize ri_RootToPartitionMap to use for non-partition childr

From: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Generalize ri_RootToPartitionMap to use for non-partition childr
Date: 2022-12-02 09:36:55
Message-ID: E1p12TW-001gN5-8N@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Generalize ri_RootToPartitionMap to use for non-partition children

ri_RootToPartitionMap is currently only initialized for tuple routing
target partitions, though a future commit will need the ability to use
it even for the non-partition child tables, so make adjustments to the
decouple it from the partitioning code.

Also, make it lazily initialized via ExecGetRootToChildMap(), making
that function its preferred access path. Existing third-party code
accessing it directly should no longer do so; consequently, it's been
renamed to ri_RootToChildMap, which also makes it consistent with
ri_ChildToRootMap.

ExecGetRootToChildMap() houses the logic of setting the map appropriately
depending on whether a given child relation is partition or not.

To support this, also add a separate entry point for TupleConversionMap
creation that receives an AttrMap. No new code here, just split an
existing function in two.

Author: Amit Langote <amitlangote09(at)gmail(dot)com>
Discussion: https://postgr.es/m/CA+HiwqEYUhDXSK5BTvG_xk=eaAEJCD4GS3C6uH7ybBvv+Z_Tmg@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/fb958b5da86da69651f6fb9f540c2cfb1346cdc5

Modified Files
--------------
src/backend/access/common/tupconvert.c | 19 +++++++++--
src/backend/commands/copyfrom.c | 2 +-
src/backend/executor/execMain.c | 8 +++--
src/backend/executor/execPartition.c | 27 +++++----------
src/backend/executor/execUtils.c | 57 +++++++++++++++++++++++++++-----
src/backend/executor/nodeModifyTable.c | 2 +-
src/backend/replication/logical/worker.c | 4 +--
src/include/access/tupconvert.h | 3 ++
src/include/executor/executor.h | 1 +
src/include/nodes/execnodes.h | 30 +++++++++--------
10 files changed, 104 insertions(+), 49 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Daniel Gustafsson 2022-12-02 10:40:22 pgsql: doc: fix type alignment for CREATE TABLE in triggers
Previous Message Amit Kapila 2022-12-02 05:45:14 pgsql: Fix incorrect output from pgoutput when using column lists.