pgsql: autoconf: Unify CFLAGS_SSE42 and CFLAGS_ARMV8_CRC32C

From: Andres Freund <andres(at)anarazel(dot)de>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: autoconf: Unify CFLAGS_SSE42 and CFLAGS_ARMV8_CRC32C
Date: 2022-12-02 03:01:23
Message-ID: E1p0wIk-001e7y-PT@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

autoconf: Unify CFLAGS_SSE42 and CFLAGS_ARMV8_CRC32C

Until now we emitted the cflags to build the CRC objects into architecture
specific variables. That doesn't make a whole lot of sense to me - we're never
going to target x86 and arm at the same time, so they don't need to be
separate variables.

It might be better to instead continue to have CFLAGS_SSE42 /
CFLAGS_ARMV8_CRC32C be computed by PGAC_ARMV8_CRC32C_INTRINSICS /
PGAC_SSE42_CRC32_INTRINSICS and then set CFLAGS_CRC based on those. But it
seems unlikely that we'd need other sets of CRC specific flags for those two
architectures at the same time.

This simplifies the upcoming meson PGXS compatibility.

Reviewed-by: Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>
Discussion: https://postgr.es/m/20221005200710.luvw5evhwf6clig6@awork3.anarazel.de

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/e0f0e08e17a6186ce299ed8a4385a7a486f304ed

Modified Files
--------------
config/c-compiler.m4 | 8 ++++----
configure | 19 +++++++++----------
configure.ac | 10 +++++-----
src/Makefile.global.in | 3 +--
src/port/Makefile | 18 +++++++++---------
5 files changed, 28 insertions(+), 30 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Andres Freund 2022-12-02 03:14:21 pgsql: autoconf: Don't AC_SUBST() LD in configure
Previous Message Andrew Dunstan 2022-12-02 02:55:10 Re: pgsql: Expand AclMode to 64 bits