pgsql: Improve heuristics for compressing the KnownAssignedXids array.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Improve heuristics for compressing the KnownAssignedXids array.
Date: 2022-11-29 20:43:35
Message-ID: E1p07S2-001L6F-Rr@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Improve heuristics for compressing the KnownAssignedXids array.

Previously, we'd compress only when the active range of array entries
reached Max(4 * PROCARRAY_MAXPROCS, 2 * pArray->numKnownAssignedXids).
If max_connections is large, the first term could result in not
compressing for a long time, resulting in much wastage of cycles in
hot-standby backends scanning the array to take snapshots. Get rid
of that term, and just bound it to 2 * pArray->numKnownAssignedXids.

That however creates the opposite risk, that we might spend too much
effort compressing. Hence, consider compressing only once every 128
commit records. (This frequency was chosen by benchmarking. While
we only tried one benchmark scenario, the results seem stable over
a fairly wide range of frequencies.)

Also, force compression when processing RecoveryInfo WAL records
(which should be infrequent); the old code could perform compression
then, but would do so only after the same array-range check as for
the transaction-commit path.

Also, opportunistically run compression if the startup process is about
to wait for WAL, though not oftener than once a second. This should
prevent cases where we waste lots of time by leaving the array
not-compressed for long intervals due to low WAL traffic.

Lastly, add a simple check to keep us from uselessly compressing
when the array storage is already compact.

Back-patch, as the performance problem is worse in pre-v14 branches
than in HEAD.

Simon Riggs and Michail Nikolaev, with help from Tom Lane and
Andres Freund.

Discussion: https://postgr.es/m/CALdSSPgahNUD_=pB_j=1zSnDBaiOtqVfzo8Ejt5J_k7qZiU1Tw@mail.gmail.com

Branch
------
REL_12_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/c4a153d778318afbc0d2cd92067f49b62673444f

Modified Files
--------------
src/backend/access/transam/xlog.c | 6 ++
src/backend/storage/ipc/procarray.c | 133 ++++++++++++++++++++++++++++--------
src/include/storage/procarray.h | 1 +
3 files changed, 110 insertions(+), 30 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Michael Paquier 2022-11-29 23:39:36 pgsql: Fix comment in fe-auth-scram.c
Previous Message Robert Haas 2022-11-29 19:34:01 Re: pgsql: Revoke PUBLIC CREATE from public schema, now owned by pg_databas