From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | pgsql: Add comments and a missing CHECK_FOR_INTERRUPTS in ts_headline. |
Date: | 2022-11-21 22:07:46 |
Message-ID: | E1oxEx7-000GqQ-9C@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Add comments and a missing CHECK_FOR_INTERRUPTS in ts_headline.
I just spent an annoying amount of time reverse-engineering the
100%-undocumented API between ts_headline and the text search
parser's prsheadline function. Add some commentary about that
while it's fresh in mind. Also remove some unused macros in
wparser_def.c.
While at it, I noticed that when commit 78e73e875 added a
CHECK_FOR_INTERRUPTS call in TS_execute_recurse, it missed
doing so in the parallel function TS_phrase_execute, which
surely needs one just as much.
Back-patch because of the missing CHECK_FOR_INTERRUPTS.
Might as well back-patch the rest of this too.
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/5644d6f909b1bc92155741064275cda82d9b9b70
Modified Files
--------------
src/backend/tsearch/ts_parse.c | 13 ++++++++
src/backend/tsearch/wparser_def.c | 4 ---
src/backend/utils/adt/tsvector_op.c | 3 ++
src/include/tsearch/ts_public.h | 61 ++++++++++++++++++++++++++-----------
4 files changed, 60 insertions(+), 21 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Daniel Gustafsson | 2022-11-21 22:29:29 | pgsql: Replace link to Hunspell with the current homepage |
Previous Message | Andres Freund | 2022-11-21 22:01:02 | pgsql: Add workaround to make ubsan and ps_status.c compatible |