pgsql: Don't read MCV stats needlessly in eqjoinsel().

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Don't read MCV stats needlessly in eqjoinsel().
Date: 2022-11-18 16:01:13
Message-ID: E1ow3nl-000l5G-0y@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Don't read MCV stats needlessly in eqjoinsel().

eqjoinsel() currently makes use of MCV stats only when we have such
stats for both sides of the clause. As coded, though, it would
fetch those stats even when they're present for just one side.
This can be a bit expensive with high statistics targets, leading
to wasted effort in common cases such as joining a unique column
to a non-unique column. So it seems worth the trouble to do a quick
pre-check to confirm that both sides have MCVs before fetching either.

Also, tweak the API spec for get_attstatsslot() to document the
method we're using here.

David Geier, Tomas Vondra, Tom Lane

Discussion: https://postgr.es/m/b9846ca0-5f1c-9b26-5881-aad3f42b07f0@gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/f84ff0c6d4eb4e470e55f48103a7edd269d13c49

Modified Files
--------------
src/backend/utils/adt/selfuncs.c | 20 ++++++++++++++++++--
src/backend/utils/cache/lsyscache.c | 4 ++++
2 files changed, 22 insertions(+), 2 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Robert Haas 2022-11-18 18:42:45 pgsql: Add a SET option to the GRANT command.
Previous Message Peter Eisentraut 2022-11-18 15:08:37 pgsql: Make object_address test output easier to update