| From: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
|---|---|
| To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | pgsql: libpq: Handle NegotiateProtocolVersion message |
| Date: | 2022-11-17 14:47:56 |
| Message-ID: | E1ovgBH-000c36-TO@gemulon.postgresql.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
libpq: Handle NegotiateProtocolVersion message
Before, receiving a NegotiateProtocolVersion message would result in a
confusing error message like
expected authentication request from server, but received v
This adds proper handling of this protocol message and produces an
on-topic error message from it.
Reviewed-by: Jacob Champion <jchampion(at)timescale(dot)com>
Reviewed-by: Nathan Bossart <nathandbossart(at)gmail(dot)com>
Discussion: https://www.postgresql.org/message-id/flat/f9c7862f-b864-8ef7-a861-c4638c83e209%40enterprisedb.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/bbf9c282ce92272ed7bf6771daf0f9efa209e61b
Modified Files
--------------
src/interfaces/libpq/fe-connect.c | 22 +++++++++++----
src/interfaces/libpq/fe-protocol3.c | 55 +++++++++++++++++++++++++++++++++++++
src/interfaces/libpq/libpq-int.h | 1 +
3 files changed, 73 insertions(+), 5 deletions(-)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Noah Misch | 2022-11-17 15:51:47 | pgsql: Account for IPC::Run::result() Windows behavior change. |
| Previous Message | Peter Eisentraut | 2022-11-17 13:40:18 | pgsql: libpq: Correct processing of startup response messages |