From: | Amit Kapila <akapila(at)postgresql(dot)org> |
---|---|
To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | pgsql: Fix cleanup lock acquisition in SPLIT_ALLOCATE_PAGE replay. |
Date: | 2022-11-14 05:23:57 |
Message-ID: | E1ouRwq-00072T-T1@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Fix cleanup lock acquisition in SPLIT_ALLOCATE_PAGE replay.
During XLOG_HASH_SPLIT_ALLOCATE_PAGE replay, we were checking for a
cleanup lock on the new bucket page after acquiring an exclusive lock on
it and raising a PANIC error on failure. However, it is quite possible
that checkpointer can acquire the pin on the same page before acquiring a
lock on it, and then the replay will lead to an error. So instead, directly
acquire the cleanup lock on the new bucket page during
XLOG_HASH_SPLIT_ALLOCATE_PAGE replay operation.
Reported-by: Andres Freund
Author: Robert Haas
Reviewed-By: Amit Kapila, Andres Freund, Vignesh C
Backpatch-through: 11
Discussion: https://postgr.es/m/20220810022617.fvjkjiauaykwrbse@awork3.anarazel.de
Branch
------
REL_12_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/4dccccb37e0b87bc3f941ea2c7f0b9e51661bc79
Modified Files
--------------
src/backend/access/hash/hash_xlog.c | 5 ++---
src/backend/access/hash/hashpage.c | 10 +++++++---
2 files changed, 9 insertions(+), 6 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Amit Kapila | 2022-11-15 04:18:02 | pgsql: Improve comments referring snapshot's subxip array. |
Previous Message | Michael Paquier | 2022-11-14 02:59:41 | pgsql: Add error context callback when tokenizing authentication files |