pgsql: If wait_for_catchup fails under has_wal_read_bug, skip balance o

From: Noah Misch <noah(at)leadboat(dot)com>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: If wait_for_catchup fails under has_wal_read_bug, skip balance o
Date: 2022-11-12 19:24:05
Message-ID: E1otw6m-000oEm-Ec@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

If wait_for_catchup fails under has_wal_read_bug, skip balance of test.

Test files should now ignore has_wal_read_bug() so long as
wait_for_catchup() is their only known way of reaching the bug. That's
at least five files today, a number expected to grow over time. This
commit removes skip logic from three. By doing so, systems having the
bug regain the ability to catch other kinds of defects via those three
tests. The other two, 002_databases.pl and 031_recovery_conflict.pl,
have been unprotected. Back-patch to v15, where done_testing() first
became our standard.

Discussion: https://postgr.es/m/20221030031639.GA3082137@rfd.leadboat.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/30d98e14a88930c6d9658525fd5e6722e70a02e6

Modified Files
--------------
contrib/bloom/t/001_wal.pl | 7 -------
src/test/perl/PostgreSQL/Test/Cluster.pm | 19 +++++++++++++++++--
src/test/recovery/t/027_stream_regress.pl | 7 -------
src/test/recovery/t/032_relfilenode_reuse.pl | 7 -------
4 files changed, 17 insertions(+), 23 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Peter Eisentraut 2022-11-12 19:44:18 pgsql: Add repalloc0 and repalloc0_array
Previous Message Tom Lane 2022-11-12 18:30:09 pgsql: Fix volatility marking of timestamptz_trunc_zone.