From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | pgsql: Fix alter_table.sql test case to test what it claims to. |
Date: | 2022-11-10 22:24:41 |
Message-ID: | E1otFyT-000X2i-1N@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Fix alter_table.sql test case to test what it claims to.
The stanza "SET STORAGE may need to add a TOAST table" does not
test what it's supposed to, and hasn't done so since we added
the ability to store constant column default values as metadata.
We need to use a non-constant default to get the expected table
rewrite to actually happen.
Fix that, and add the missing checks that would have exposed the
problem to begin with.
Noted while reviewing a patch that made changes in this test case.
Back-patch to v11 where the problem came in.
Branch
------
REL_12_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/6a1396fd19a3cefc71e176931c9e02a3b12d32eb
Modified Files
--------------
src/test/regress/expected/alter_table.out | 30 ++++++++++++++++++++++--------
src/test/regress/sql/alter_table.sql | 11 +++++++----
2 files changed, 29 insertions(+), 12 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2022-11-10 23:20:57 | pgsql: Support writing "CREATE/ALTER TABLE ... SET STORAGE DEFAULT". |
Previous Message | Tom Lane | 2022-11-10 15:24:00 | pgsql: Re-allow building on Microsoft Visual Studio 2013. |