pgsql: Report a more useful error for reloptions on a partitioned table

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Report a more useful error for reloptions on a partitioned table
Date: 2022-11-09 17:28:38
Message-ID: E1ososP-000LkG-6v@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Report a more useful error for reloptions on a partitioned table.

Previously, trying to set storage parameters on a partitioned table
always led to "unrecognized parameter foo", because the code expected
there might be some valid parameters; but there aren't any. The docs
make clear that it's intended that there never will be any, so let's
replace this useless search with a more to-the-point message.

Simon Riggs and Karina Litskevich

Discussion: https://postgr.es/m/CANbhV-H=eZ9kTR9mUgKGK0Qv9uXP=U+dQg3rinQHfTdFMhBA2A@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/4f981df8e0b7bc00d22ab0db65579589c9d4bb8c

Modified Files
--------------
src/backend/access/common/reloptions.c | 13 ++++++-------
src/test/regress/expected/alter_table.out | 4 ++++
src/test/regress/expected/create_table.out | 4 ++++
src/test/regress/sql/alter_table.sql | 3 +++
src/test/regress/sql/create_table.sql | 3 +++
5 files changed, 20 insertions(+), 7 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Alvaro Herrera 2022-11-09 17:32:37 pgsql: Remove redundant declaration for XidInMVCCSnapshot
Previous Message Tom Lane 2022-11-09 16:09:11 pgsql: Doc: add comments about PreventInTransactionBlock/IsInTransactio