pgsql: Fix readlink() for non-PostgreSQL junction points on Windows.

From: Thomas Munro <tmunro(at)postgresql(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Fix readlink() for non-PostgreSQL junction points on Windows.
Date: 2022-10-25 03:29:42
Message-ID: E1onAdK-000gt1-AY@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Fix readlink() for non-PostgreSQL junction points on Windows.

Since commit c5cb8f3b taught stat() to follow symlinks, and since initdb
uses pg_mkdir_p(), and that examines parent directories, our humble
readlink() implementation can now be exposed to junction points not of
PostgreSQL origin. Those might be corrupted by our naive path mangling,
which doesn't really understand NT paths in general.

Simply decline to transform paths that don't look like a drive absolute
path. That means that readlink() returns the NT path directly when
checking a parent directory of PGDATA that happen to point to a drive
using "rooted" format. That works for the purposes of our stat()
emulation.

Reported-by: Roman Zharkov <r(dot)zharkov(at)postgrespro(dot)ru>
Reviewed-by: Roman Zharkov <r(dot)zharkov(at)postgrespro(dot)ru>
Discussion: https://postgr.es/m/4590c37927d7b8ee84f9855d83229018%40postgrespro.ru
Discussion: https://postgr.es/m/CA%2BhUKG%2BajSQ_8eu2AogTncOnZ5me2D-Cn66iN_-wZnRjLN%2Bicg%40mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/f71007fbb3b83fba21daae9144cc07e205f2365c

Modified Files
--------------
src/port/dirmod.c | 17 ++++++++++++++---
1 file changed, 14 insertions(+), 3 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Michael Paquier 2022-10-25 05:06:57 pgsql: Clean up some GUC declarations and comments
Previous Message Michael Paquier 2022-10-25 00:30:11 pgsql: doc: Fix type of cursor_position in jsonlog table