| From: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
|---|---|
| To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | pgsql: Fix recently added incorrect assertion |
| Date: | 2022-10-24 10:05:10 |
| Message-ID: | E1omuKU-000aIV-DU@gemulon.postgresql.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Fix recently added incorrect assertion
Commit df3737a651f4 added an incorrect assertion about the preconditions
for invoking the backup cleanup callback: it misfires at session end in
case a backup completes successfully. Fix it, using coding from Michaël
Paquier. Also add some tests for the various cases.
Reported by Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>
Discussion: https://postgr.es/m/20221021.161038.1277961198945653224.horikyota.ntt@gmail.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/8328a15f8f95cad3fa99bbab551cade0a8403708
Modified Files
--------------
src/backend/access/transam/xlog.c | 5 ++---
src/test/recovery/t/020_archive_status.pl | 14 ++++++++++++++
2 files changed, 16 insertions(+), 3 deletions(-)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2022-10-24 10:57:00 | pgsql: Update some comments that should've covered MERGE |
| Previous Message | Michael Paquier | 2022-10-24 07:56:50 | pgsql: Improve coverage of ruleutils.c for SQLValueFunctions |