From: | Michael Paquier <michael(at)paquier(dot)xyz> |
---|---|
To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | pgsql: Fix and improve TAP tests for pg_hba.conf and regexps |
Date: | 2022-10-24 04:59:19 |
Message-ID: | E1ompYV-000YEs-9Y@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Fix and improve TAP tests for pg_hba.conf and regexps
The new tests have been reporting a warning hidden in the logs, as of
"Odd number of elements in hash assignment" (perlcritic or similar did
not report an issue, actually). This comes down to a typo in the test
"matching regexp for username" for a double-quoted regexp using commas,
where we passed an extra argument. The test is intended to pass, but
this was causing the test to fail. This also pointed out that the
newly-added role "md5,role" lacks an entry in the password file used to
provide the password, so add one.
While on it, make the tests pickier by checking the contents of the logs
generated on successful authentication.
Oversights in 8fea868.
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/14a737bfdbe4f2328d7f333b207f52f9ed4ee722
Modified Files
--------------
src/test/authentication/t/001_password.pl | 19 +++++++++++++------
1 file changed, 13 insertions(+), 6 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Michael Paquier | 2022-10-24 06:51:46 | pgsql: Improve tab completion for ALTER STATISTICS <name> SET in psql |
Previous Message | Michael Paquier | 2022-10-24 02:46:49 | pgsql: Add support for regexps on database and user entries in pg_hba.c |