pgsql: Standardize format for printing PIDs

From: Peter Eisentraut <peter(at)eisentraut(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Standardize format for printing PIDs
Date: 2022-10-14 06:49:42
Message-ID: E1ojEVq-002Ino-0v@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Standardize format for printing PIDs

Most code prints PIDs as %d, but some code tried to print them as long
or unsigned long. While this is in theory allowed, the fact that PIDs
fit into int is deeply baked into all PostgreSQL code, so these random
deviations don't accomplish anything except confusion.

Note that we still need casts from pid_t to int, because on 64-bit
MinGW, pid_t is long long int. (But per above, actually supporting
that range in PostgreSQL code would be major surgery and probably not
useful.)

Discussion: https://www.postgresql.org/message-id/289c2e45-c7d9-5ce4-7eff-a9e2a33e1580@enterprisedb.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/1b11561cc1de7596f6f7cb750743af94b9d168f7

Modified Files
--------------
contrib/pg_prewarm/autoprewarm.c | 20 ++++++++++----------
src/backend/postmaster/bgworker.c | 4 ++--
src/backend/storage/ipc/procsignal.c | 4 ++--
3 files changed, 14 insertions(+), 14 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2022-10-14 16:36:28 pgsql: Replace the sorted array of GUC variables with a hash table.
Previous Message David Rowley 2022-10-14 01:32:23 pgsql: Fix incorrect comment regarding command completion tags