Quick Links

pgsql: autoconf: Rely on ar supporting index creation

From:	Andres Freund <andres(at)anarazel(dot)de>
To:	pgsql-committers(at)lists(dot)postgresql(dot)org
Subject:	pgsql: autoconf: Rely on ar supporting index creation
Date:	2022-10-07 19:04:04
Message-ID:	E1ogsdg-001LzD-90@gemulon.postgresql.org
Views:	Raw Message \| Whole Thread \| Download mbox \| Resend email
Thread:
Lists:	pgsql-committers

autoconf: Rely on ar supporting index creation

This way we don't need RANLIB anymore, making it a bit simpler for the meson
build to generate Makefile.global for PGXS compatibility.

FreeBSD, NetBSD, OpenBSD, the only platforms where we didn't use AROPT=crs,
all have supported the 's' option for a long time.

On macOS we ran ranlib after installing a static library. This was added a
long time ago, in 58ad65ec2def. I cannot reproduce an issue in more recent
macOS versions. This is removed now.

Based on discussion with Tom, I left the 'touch' at the end of static
libraries generation, added in 826eff57c4c, in place. While it looks like
current versions of Apple's ar/ranlib don't need it, it was needed not too
long ago.

Reviewed-by: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Discussion: https://postgr.es/m/20221005200710.luvw5evhwf6clig6@awork3.anarazel.de

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/2473cb9ff374dff99437138c144fab6d9f7dfd26

Browse pgsql-committers by date

	From	Date	Subject
Next Message	Peter Eisentraut	2022-10-08 11:50:38	pgsql: Use fabsf() instead of Abs() or fabs() where appropriate
Previous Message	Tom Lane	2022-10-07 17:59:18	Re: pgsql: Remove unnecessary uses of Abs()