pgsql: Harmonize parameter names in pg_dump/pg_dumpall.

Harmonize parameter names in pg_dump/pg_dumpall.

Make sure that function declarations use names that exactly match the
corresponding names from function definitions in pg_dump/pg_dumpall
related code.

Affected code happens to be inconsistent in how it applies conventions
around how Archive and Archive Handle variables are named. Significant
code churn is required to fully fix those inconsistencies, so take the
least invasive approach possible: treat function definition names as
authoritative, and mechanically adjust corresponding names from function
definitions to match.

Like other recent commits that cleaned up function parameter names, this
commit was written with help from clang-tidy.

Author: Peter Geoghegan <pg(at)bowt(dot)ie>
Reviewed-By: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Discussion: https://postgr.es/m/CAH2-Wzmma+vzcO6gr5NYDZ+sx0G14aU-UrzFutT2FoRaisVCUQ@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/20e69daa1348f6899fffe3c260bf44293551ee87

Modified Files
--------------
src/bin/pg_dump/common.c | 2 +-
src/bin/pg_dump/pg_backup.h | 14 +++++++-------
src/bin/pg_dump/pg_backup_archiver.h | 2 +-
src/bin/pg_dump/pg_backup_custom.c | 2 +-
src/bin/pg_dump/pg_backup_directory.c | 2 +-
src/bin/pg_dump/pg_backup_tar.c | 4 ++--
src/bin/pg_dump/pg_dump.c | 8 ++++----
src/bin/pg_dump/pg_dump.h | 6 +++---
src/bin/pg_dump/pg_dumpall.c | 6 ++++--
9 files changed, 24 insertions(+), 22 deletions(-)