pgsql: Used optimized linear search in more code paths

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Used optimized linear search in more code paths
Date: 2022-09-22 00:48:15
Message-ID: E1obANz-001Q8x-3H@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Used optimized linear search in more code paths

This commit updates two code paths to use pg_lfind32() introduced by
b6ef167 with TransactionId arrays:
- At the end of TransactionIdIsInProgress(), when checking for the case
of still running but overflowed subxids.
- XidIsConcurrent(), when checking for a serializable conflict.

These cases are less impactful than 37a6e5d, but a bit of
micro-benchmarking of this API shows that linear search speeds up by
~20% depending on the number of items involved (x86_64 and amd64 looked
at here).

Author: Nathan Bossart
Reviewed-by: Richard Guo, Michael Paquier
Discussion: https://postgr.es/m/20220901185153.GA783106@nathanxps13

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/14ff44f80c09718d43d853363941457f5468cc03

Modified Files
--------------
src/backend/storage/ipc/procarray.c | 12 ++++--------
src/backend/storage/lmgr/predicate.c | 10 ++--------
2 files changed, 6 insertions(+), 16 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Fujii Masao 2022-09-22 03:57:36 pgsql: docs: Fix snapshot name in SET TRANSACTION docs.
Previous Message Fujii Masao 2022-09-22 00:26:48 pgsql: psql: Improve tab-completion for MERGE.