| From: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
|---|---|
| To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | pgsql: Fix `trap` in a few shell scripts |
| Date: | 2022-09-20 17:05:12 |
| Message-ID: | E1oaggJ-001Dnx-Mb@gemulon.postgresql.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Fix `trap` in a few shell scripts
The original `trap` lines in these scripts are incomplete: in case of
any signal, they delete the working directory but let the script run to
completion, which is useless because it will only proceed to complain
about the working directory being removed. Add `exit` there, with the
original exit value (not rm's).
Since this is mostly just cosmetic, no backpatch.
Discussion: https://postgr.es/m/20220913181002.hzsosy7qkemb7ky7@alvherre.pgsql
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/3d53b9ef1a4cda7b6303a0496f8531eceeef0e77
Modified Files
--------------
src/tools/find_static | 2 +-
src/tools/make_ctags | 2 +-
src/tools/pginclude/cpluspluscheck | 2 +-
src/tools/pginclude/headerscheck | 6 +++---
src/tools/pgtest | 2 +-
5 files changed, 7 insertions(+), 7 deletions(-)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jeff Davis | 2022-09-20 17:53:05 | pgsql: Improve comment for OAT_POST_CREATE. |
| Previous Message | Tom Lane | 2022-09-20 16:05:10 | pgsql: Suppress variable-set-but-not-used warnings from clang 15. |