pgsql: Extend gendef.pl in preparation for meson

From: Andres Freund <andres(at)anarazel(dot)de>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Extend gendef.pl in preparation for meson
Date: 2022-09-19 22:42:03
Message-ID: E1oaPSl-0016nh-1N@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Extend gendef.pl in preparation for meson

The main issue with using gendef.pl as-is for meson is that with meson the
filenames are a bit longer, exceeding the max commandline length when calling
dumpbin with all objects. As it's easier to pass in a library anyway, do so.

The .def file location, input and temporary file location need to be tunable
as well.

This also fixes a bug in gendef.pl: The logic when to regenerate was broken
and never avoid regenerating.

Author: Andres Freund <andres(at)anarazel(dot)de>
Reviewed-By: Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>
Discussion: https://postgr.es/m/20220809071055.rgikv3qn74ypnnbb@awork3.anarazel.de
Discussion: https://postgr.es/m/7dae5979-c6c0-cec5-7a36-76a85aa8053d@enterprisedb.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/70df2df1cc89e69e31b31b6aa0d65fd72935af38

Modified Files
--------------
src/tools/msvc/MSBuildProject.pm | 4 ++-
src/tools/msvc/gendef.pl | 67 +++++++++++++++++++++++++++-------------
2 files changed, 49 insertions(+), 22 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Peter Geoghegan 2022-09-19 22:48:03 pgsql: Consistently use named parameters in regex code consistently.
Previous Message Tom Lane 2022-09-19 22:39:59 Re: pgsql: Add support for MERGE SQL command