pgsql: Consistently use named parameters in timezone code.

From: Peter Geoghegan <pg(at)bowt(dot)ie>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Consistently use named parameters in timezone code.
Date: 2022-09-19 22:15:07
Message-ID: E1oaP2g-0016ay-Uy@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Consistently use named parameters in timezone code.

Make our copy of the IANA timezone library use named parameters in
function declarations. Also make sure that parameter names from each
function's declaration match corresponding definition parameter names.

This makes the timezone code follow Postgres coding standards. The
value of having a consistent standard everywhere seems to outweigh the
cost of keeping the function declarations in sync with future IANA
releases.

Author: Peter Geoghegan <pg(at)bowt(dot)ie>
Reviewed-By: David Rowley <dgrowleyml(at)gmail(dot)com>
Discussion: https://postgr.es/m/CAH2-WznJt9CMM9KJTMjJh_zbL5hD9oX44qdJ4aqZtjFi-zA3Tg@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/c4f8e89fef3d4cd8b0791637667fd984d6f38fb2

Modified Files
--------------
src/timezone/localtime.c | 16 +++++++++-------
src/timezone/pgtz.c | 8 ++++----
src/timezone/strftime.c | 10 +++++-----
src/timezone/zic.c | 34 ++++++++++++++++++----------------
4 files changed, 36 insertions(+), 32 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2022-09-19 22:18:19 Re: pgsql: Consistently use named parameters in regex code.
Previous Message Tom Lane 2022-09-19 22:12:59 Re: pgsql: Add support for MERGE SQL command