pgsql: Consistently use named parameters in regex code.

From: Peter Geoghegan <pg(at)bowt(dot)ie>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Consistently use named parameters in regex code.
Date: 2022-09-19 22:11:40
Message-ID: E1oaOzL-0016XZ-NN@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Consistently use named parameters in regex code.

Make regex code consistently use named parameters in function
declarations. Also make sure that parameter names from each function's
declaration match corresponding definition parameter names.

This makes Henry Spencer's regex code follow Postgres coding standards.

Author: Peter Geoghegan <pg(at)bowt(dot)ie>
Reviewed-By: David Rowley <dgrowleyml(at)gmail(dot)com>
Discussion: https://postgr.es/m/CAH2-WznJt9CMM9KJTMjJh_zbL5hD9oX44qdJ4aqZtjFi-zA3Tg@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/bc2187ed63c56bb9cd99f6613f3e2ba56afb22fe

Modified Files
--------------
src/backend/regex/regcomp.c | 342 +++++++++++++++++--------------
src/backend/regex/regexec.c | 65 +++---
src/backend/utils/adt/regexp.c | 2 +-
src/include/regex/regex.h | 14 +-
src/test/modules/test_regex/test_regex.c | 2 +-
5 files changed, 241 insertions(+), 184 deletions(-)

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2022-09-19 22:12:59 Re: pgsql: Add support for MERGE SQL command
Previous Message David Rowley 2022-09-19 22:04:41 pgsql: Fix misleading comment for get_cheapest_group_keys_order