From: | Daniel Gustafsson <dgustafsson(at)postgresql(dot)org> |
---|---|
To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | pgsql: Fix NaN comparison in circle_same test |
Date: | 2022-09-12 11:07:13 |
Message-ID: | E1oXhHU-002de5-UL@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Fix NaN comparison in circle_same test
Commit c4c340088 changed geometric operators to use float4 and float8
functions, and handle NaN's in a better way. The circle sameness test
had a typo in the code which resulted in all comparisons with the left
circle having a NaN radius considered same.
postgres=# select '<(0,0),NaN>'::circle ~= '<(0,0),1>'::circle;
?column?
----------
t
(1 row)
This fixes the sameness test to consider the radius of both the left
and right circle.
Backpatch to v12 where this was introduced.
Author: Ranier Vilela <ranier(dot)vf(at)gmail(dot)com>
Discussion: https://postgr.es/m/CAEudQAo8dK=yctg2ZzjJuzV4zgOPBxRU5+Kb+yatFiddtQk6Rw@mail.gmail.com
Backpatch-through: v12
Branch
------
REL_12_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/9ebfbd23bcdefa7cb7abd1ecdd80aa1f9be6eede
Modified Files
--------------
src/backend/utils/adt/geo_ops.c | 2 +-
src/test/regress/expected/geometry.out | 3 +--
2 files changed, 2 insertions(+), 3 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Peter Eisentraut | 2022-09-12 14:51:26 | pgsql: Add list of acknowledgments to release notes |
Previous Message | Daniel Gustafsson | 2022-09-12 11:06:57 | pgsql: Fix NaN comparison in circle_same test |