pgsql: Fix NaN comparison in circle_same test

From: Daniel Gustafsson <dgustafsson(at)postgresql(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Fix NaN comparison in circle_same test
Date: 2022-09-12 11:05:39
Message-ID: E1oXhFz-002dao-F7@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Fix NaN comparison in circle_same test

Commit c4c340088 changed geometric operators to use float4 and float8
functions, and handle NaN's in a better way. The circle sameness test
had a typo in the code which resulted in all comparisons with the left
circle having a NaN radius considered same.

postgres=# select '<(0,0),NaN>'::circle ~= '<(0,0),1>'::circle;
?column?
----------
t
(1 row)

This fixes the sameness test to consider the radius of both the left
and right circle.

Backpatch to v12 where this was introduced.

Author: Ranier Vilela <ranier(dot)vf(at)gmail(dot)com>
Discussion: https://postgr.es/m/CAEudQAo8dK=yctg2ZzjJuzV4zgOPBxRU5+Kb+yatFiddtQk6Rw@mail.gmail.com
Backpatch-through: v12

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/8cb2a22bbb2cf4212482ac15021ceaa2e9c52209

Modified Files
--------------
src/backend/utils/adt/geo_ops.c | 2 +-
src/test/regress/expected/geometry.out | 3 +--
2 files changed, 2 insertions(+), 3 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Daniel Gustafsson 2022-09-12 11:06:24 pgsql: Fix NaN comparison in circle_same test
Previous Message Dagfinn Ilmari Mannsåker 2022-09-12 09:54:47 Re: pgsql: Fix perltidy breaking perlcritic