pgAdmin 4 commit: Fixed SonarQube issues.

Fixed SonarQube issues.

Branch
------
master

Details
-------
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=708671964030d1c62d095846ec23f5e2fd4a24e6

Modified Files
--------------
docs/en_US/release_notes_6_14.rst | 1 +
runtime/src/js/misc.js | 2 +-
.../authenticate/mfa/templates/mfa/email.js | 6 +-
.../servers/databases/casts/static/js/cast.js | 4 +-
.../servers/databases/casts/static/js/cast.ui.js | 4 +-
.../user_mappings/static/js/user_mapping.js | 8 +-
.../publications/static/js/publication.ui.js | 4 +-
.../schemas/domains/static/js/domain.ui.js | 4 +-
.../databases/schemas/foreign_tables/__init__.py | 12 -
.../foreign_tables/static/js/foreign_table.ui.js | 10 +-
.../static/js/fts_configuration.ui.js | 4 +-
.../databases/schemas/functions/__init__.py | 8 -
.../schemas/functions/static/js/function.ui.js | 4 +-
.../schemas/functions/static/js/procedure.js | 2 +-
.../schemas/packages/static/js/package.js | 4 +-
.../schemas/sequences/static/js/sequence.ui.js | 2 +-
.../servers/databases/schemas/static/js/schema.js | 18 +-
.../databases/schemas/static/js/schema.ui.js | 2 +-
.../schemas/synonyms/static/js/synonym.js | 4 +-
.../schemas/tables/columns/static/js/column.js | 2 +-
.../schemas/tables/columns/static/js/column.ui.js | 10 +-
.../static/js/compound_trigger.js | 14 +-
.../static/js/compound_trigger.ui.js | 10 +-
.../check_constraint/static/js/check_constraint.js | 6 +-
.../static/js/exclusion_constraint.js | 2 +-
.../foreign_key/static/js/foreign_key.js | 6 +-
.../foreign_key/static/js/foreign_key.ui.js | 2 +-
.../index_constraint/static/js/primary_key.js | 64 ++---
.../static/js/unique_constraint.js | 2 +-
.../schemas/tables/indexes/static/js/index.js | 2 +-
.../schemas/tables/indexes/static/js/index.ui.js | 6 +-
.../tables/partitions/static/js/partition.js | 22 +-
.../tables/partitions/static/js/partition.ui.js | 4 +-
.../static/js/row_security_policy.js | 2 +-
.../static/js/row_security_policy.ui.js | 2 +-
.../schemas/tables/rules/static/js/rule.js | 22 +-
.../schemas/tables/static/js/partition.utils.ui.js | 4 +-
.../databases/schemas/tables/static/js/table.js | 30 +-
.../databases/schemas/tables/static/js/table.ui.js | 6 +-
.../schemas/tables/triggers/static/js/trigger.js | 12 +-
.../tables/triggers/static/js/trigger.ui.js | 32 +--
.../databases/schemas/types/static/js/type.ui.js | 44 +--
.../databases/schemas/views/static/js/mview.js | 6 +-
.../servers/databases/static/js/database.js | 38 +--
.../subscriptions/static/js/subscription.js | 2 +-
.../subscriptions/static/js/subscription.ui.js | 8 +-
.../servers/pgagent/static/js/pga_job.js | 2 +-
.../servers/pgagent/steps/static/js/pga_jobstep.js | 2 +-
.../resource_groups/static/js/resource_group.js | 2 +-
.../server_groups/servers/roles/static/js/role.js | 6 +-
.../servers/roles/static/js/role.ui.js | 6 +-
.../server_groups/servers/static/js/privilege.js | 64 ++---
.../server_groups/servers/static/js/server.js | 48 ++--
.../server_groups/servers/static/js/server.ui.js | 38 +--
.../server_groups/servers/static/js/vacuum.ui.js | 2 +-
.../server_groups/servers/static/js/variable.js | 56 ++--
.../server_groups/servers/static/js/variable.ui.js | 2 +-
.../servers/tablespaces/static/js/tablespace.js | 6 +-
.../server_groups/static/js/server_group.js | 4 +-
web/pgadmin/browser/static/js/collection.js | 12 +-
web/pgadmin/browser/static/js/datamodel.js | 142 +++++-----
web/pgadmin/browser/static/js/frame.js | 12 +-
web/pgadmin/browser/static/js/layout.js | 10 +-
web/pgadmin/browser/static/js/menu.js | 56 ++--
web/pgadmin/browser/static/js/node.ui.js | 50 ++--
web/pgadmin/browser/static/js/node_ajax.js | 22 +-
web/pgadmin/browser/static/js/panel.js | 18 +-
web/pgadmin/browser/static/js/preferences.js | 6 +-
web/pgadmin/browser/static/js/toolbar.js | 2 +-
.../browser/templates/browser/js/messages.js | 4 +-
web/pgadmin/browser/templates/browser/js/utils.js | 8 +-
web/pgadmin/help/static/js/help.js | 4 +-
web/pgadmin/misc/cloud/static/js/aws.js | 2 +-
web/pgadmin/misc/cloud/static/js/azure.js | 2 +-
web/pgadmin/misc/cloud/static/js/cloud.js | 2 +-
web/pgadmin/preferences/static/js/preferences.js | 6 +-
web/pgadmin/settings/static/js/settings.js | 2 +-
web/pgadmin/static/bundle/app.js | 6 +-
web/pgadmin/static/bundle/codemirror.js | 2 +-
web/pgadmin/static/js/SchemaView/FormView.jsx | 2 +-
web/pgadmin/static/js/backform.pgadmin.js | 304 ++++++++++-----------
web/pgadmin/static/js/check_node_visibility.js | 4 +-
.../codemirror/addon/fold/pgadmin-sqlfoldcode.js | 27 +-
.../js/codemirror/extension/centre_on_line.js | 4 +-
web/pgadmin/static/js/csrf.js | 4 +-
web/pgadmin/static/js/dialog_tab_navigator.js | 10 +-
web/pgadmin/static/js/gettext.js | 2 +-
web/pgadmin/static/js/is_native.js | 10 +-
web/pgadmin/static/js/pgadmin.js | 8 +-
.../static/js/select2/configure_show_on_scroll.js | 14 +-
web/pgadmin/static/js/selection/clipboard.js | 6 +-
.../js/selection/range_boundary_navigator.js | 32 +--
web/pgadmin/static/js/selection/set_staged_rows.js | 16 +-
.../static/js/tree/pgadmin_tree_save_state.js | 16 +-
web/pgadmin/static/js/url_for.js | 4 +-
web/pgadmin/static/js/utils.js | 38 +--
web/pgadmin/static/js/validators.js | 4 +-
web/pgadmin/tools/backup/static/js/backup.js | 46 ++--
web/pgadmin/tools/backup/static/js/backup.ui.js | 10 +-
.../tools/backup/static/js/backupGlobal.ui.js | 2 +-
.../tools/debugger/static/js/DebuggerModule.js | 34 +--
.../js/components/DebuggerArgumentComponent.jsx | 3 +-
.../tools/debugger/static/js/debugger_ui.js | 2 +-
.../tools/debugger/static/js/debugger_utils.js | 18 +-
web/pgadmin/tools/erd/static/js/ERDModule.js | 14 +-
.../tools/grant_wizard/static/js/grant_wizard.js | 2 +-
.../tools/import_export/static/js/import_export.js | 18 +-
.../import_export/static/js/import_export.ui.js | 2 +-
.../static/js/import_export_servers.js | 2 +-
.../tools/maintenance/static/js/maintenance.js | 22 +-
.../tools/maintenance/static/js/maintenance.ui.js | 4 +-
web/pgadmin/tools/psql/static/js/psql_module.js | 46 ++--
web/pgadmin/tools/restore/static/js/restore.js | 12 +-
web/pgadmin/tools/restore/static/js/restore.ui.js | 4 +-
.../tools/search_objects/static/js/index.js | 6 +-
.../tools/sqleditor/static/js/SQLEditorModule.js | 34 +--
.../tools/sqleditor/static/js/show_query_tool.js | 4 +-
.../tools/sqleditor/static/js/show_view_data.js | 12 +-
.../tools/sqleditor/static/js/sqleditor_title.js | 6 +-
web/regression/feature_utils/locators.py | 3 +-
.../backform_controls/keyboardshortcut_spec.js | 8 +-
web/regression/javascript/browser/layout_spec.js | 2 +-
.../javascript/browser/preferences_spec.js | 4 +-
.../javascript/check_node_visibility_spec.js | 2 +-
.../javascript/dialog_tab_navigator_spec.js | 8 +-
web/regression/javascript/fake_messages.js | 2 +-
.../javascript/nodes/schema/child_menu_spec.js | 6 +-
web/webpack.config.js | 10 +-
web/webpack.shim.js | 4 +-
129 files changed, 945 insertions(+), 981 deletions(-)