pgsql: Parse catalog .dat files as a whole when compiling the backend

From: John Naylor <john(dot)naylor(at)postgresql(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Parse catalog .dat files as a whole when compiling the backend
Date: 2022-09-08 06:57:37
Message-ID: E1oWBTl-001xgw-B5@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Parse catalog .dat files as a whole when compiling the backend

Previously Catalog.pm eval'd each individual hash reference
so that comments and whitespace can be preserved when running
reformat-dat-files. This is unnecessary when building, and we can save
~15% off the run time of genbki.pl by simply slurping and eval'-ing
the whole file at once. This saves a bit of time, especially in highly
parallel builds, since most build targets depend on this script's outputs.

Report and review by Andres Freund
Discussion: https://www.postgresql.org/message-id/CAFBsxsGW%3DWRbnxXrc8UqqR479XuxtukSFWV-hnmtgsbuNAUO6w%40mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/69eb643b2582f180c91b2d14c896402e54040231

Modified Files
--------------
src/backend/catalog/Catalog.pm | 22 ++++++++++++++++++++--
1 file changed, 20 insertions(+), 2 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message John Naylor 2022-09-08 07:02:30 pgsql: Run perltidy over Catalog.pm
Previous Message Masahiko Sawada 2022-09-08 06:52:06 Re: pgsql: Raise a warning if there is a possibility of data from multiple