| From: | David Rowley <drowley(at)postgresql(dot)org> |
|---|---|
| To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | pgsql: Revert "Add missing padding from MemoryChunk struct" |
| Date: | 2022-08-30 15:08:08 |
| Message-ID: | E1oT2qV-000cYh-Gx@gemulon.postgresql.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Revert "Add missing padding from MemoryChunk struct"
This reverts commit df0f4feef. It turns out the problem which was causing
the 32-bit ARM and PPC animals to fail was due to a MAXALIGN problem in
slab.c. This was fixed by d5ee4db0e. The padding that was added in
df0f4feef would only do anything on machines where uint64 was not aligned
to 8 bytes. The 32-bit machines which were failing are not in that
category, so revert this commit.
Discussion: https://postgr.es/m/3209100.1661787561@sss.pgh.pa.us
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/5495796ad12aae971137d184ff25add8f6b03968
Modified Files
--------------
src/include/utils/memutils_memorychunk.h | 8 --------
1 file changed, 8 deletions(-)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David Rowley | 2022-08-30 19:35:24 | pgsql: Various cleanups of the new memory context header code |
| Previous Message | Amit Kapila | 2022-08-30 03:52:56 | pgsql: Update the comment in rmgrlist.h to match it to the code. |