pgsql: Add missing bad-PGconn guards in libpq entry points.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Add missing bad-PGconn guards in libpq entry points.
Date: 2022-08-15 19:40:30
Message-ID: E1oNfwq-000vTL-Tu@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Add missing bad-PGconn guards in libpq entry points.

There's a convention that externally-visible libpq functions should
check for a NULL PGconn pointer, and fail gracefully instead of
crashing. PQflush() and PQisnonblocking() didn't get that memo
though. Also add a similar check to PQdefaultSSLKeyPassHook_OpenSSL;
while it's not clear that ordinary usage could reach that with a
null conn pointer, it's cheap enough to check, so let's be consistent.

Daniele Varrazzo and Tom Lane

Discussion: https://postgr.es/m/CA+mi_8Zm_mVVyW1iNFgyMd9Oh0Nv8-F+7Y3-BqwMgTMHuo_h2Q@mail.gmail.com

Branch
------
REL_12_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/c19024d74e98e5c0ad95643ce584c52954d01b70

Modified Files
--------------
src/interfaces/libpq/fe-exec.c | 4 ++++
1 file changed, 4 insertions(+)

Browse pgsql-committers by date

  From Date Subject
Next Message Daniel Gustafsson 2022-08-15 21:04:16 pgsql: doc: Add unit to pg_shmem_allocations attributes
Previous Message Peter Eisentraut 2022-08-15 10:54:46 pgsql: Remove redundant spaces in _outA_Expr() output