| From: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
|---|---|
| To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | pgsql: pg_upgrade: Fix some minor code issues |
| Date: | 2022-08-12 22:18:55 |
| Message-ID: | E1oMczW-000VSK-CB@gemulon.postgresql.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
pg_upgrade: Fix some minor code issues
96ef3b8ff1cf1950e897fd2f766d4bd9ef0d5d56 accidentally copied a not
applicable comment from the float8_pass_by_value code to the
data_checksums code. Remove that.
87d3b35a1ca31a9d947a8f919a6006679216dff0 changed pg_upgrade to
checking the checksum version rather than just the Boolean presence of
checksums, but didn't change the field type in its ControlData struct
from bool. So this would not work correctly if there ever is a
checksum version larger than 1.
Branch
------
REL_10_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/d0dde35ee713c7afcd24653e2cececbdf3ede0bf
Modified Files
--------------
src/bin/pg_upgrade/controldata.c | 1 -
src/bin/pg_upgrade/pg_upgrade.h | 2 +-
2 files changed, 1 insertion(+), 2 deletions(-)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2022-08-13 08:42:17 | pgsql: Add missing fields to _outConstraint() |
| Previous Message | Peter Eisentraut | 2022-08-12 21:46:22 | pgsql: pg_upgrade: Remove unused typedef |