| From: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
|---|---|
| To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | pgsql: Reject MERGE in CTEs and COPY |
| Date: | 2022-08-12 10:28:06 |
| Message-ID: | E1oMRtd-000PaL-ME@gemulon.postgresql.org |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Reject MERGE in CTEs and COPY
The grammar added for MERGE inadvertently made it accepted syntax in
places that were not prepared to deal with it -- namely COPY and inside
CTEs, but invoking these things with MERGE currently causes assertion
failures or weird misbehavior in non-assertion builds. Protect those
places by checking for it explicitly until somebody decides to implement
it.
Reported-by: Alexey Borzov <borz_off(at)cs(dot)msu(dot)su>
Discussion: https://postgr.es/m/17579-82482cd7b267b862@postgresql.org
Branch
------
REL_15_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/455d254d22665eb7af3b714435f3fecc63696cc7
Modified Files
--------------
src/backend/commands/copy.c | 6 ++++++
src/backend/parser/parse_cte.c | 7 +++++++
src/test/regress/expected/merge.out | 14 ++++++++++++++
src/test/regress/sql/merge.sql | 10 ++++++++++
4 files changed, 37 insertions(+)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2022-08-12 11:17:33 | pgsql: MERGE docs adjustments |
| Previous Message | Peter Eisentraut | 2022-08-12 06:53:40 | pgsql: Fix _outConstraint() for "identity" constraints |