| From: | Alexander Korotkov <akorotkov(at)postgresql(dot)org> |
|---|---|
| To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | pgsql: Remove Tuplesortstate.copytup function |
| Date: | 2022-07-27 05:29:21 |
| Message-ID: | E1oGZbk-001RJu-Em@gemulon.postgresql.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Remove Tuplesortstate.copytup function
It's currently unclear how do we split functionality between
Tuplesortstate.copytup() function and tuplesort_put*() functions.
For instance, copytup_index() and copytup_datum() return error while
tuplesort_putindextuplevalues() and tuplesort_putdatum() do their work.
This commit removes Tuplesortstate.copytup() altogether, putting the
corresponding code into tuplesort_put*().
Discussion: https://postgr.es/m/CAPpHfdvjix0Ahx-H3Jp1M2R%2B_74P-zKnGGygx4OWr%3DbUQ8BNdw%40mail.gmail.com
Author: Alexander Korotkov
Reviewed-by: Pavel Borisov, Maxim Orlov, Matthias van de Meent
Reviewed-by: Andres Freund, John Naylor
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/d47da3162b4d77c888c895dd36e4ef9cb92fcf19
Modified Files
--------------
src/backend/utils/sort/tuplesort.c | 331 +++++++++++++++----------------------
1 file changed, 133 insertions(+), 198 deletions(-)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2022-07-27 06:03:30 | pgsql: Allow "in place" tablespaces. |
| Previous Message | Thomas Munro | 2022-07-27 05:01:09 | Re: pgsql: Remove the restriction that the relmap must be 512 bytes. |