From: | Andres Freund <andres(at)anarazel(dot)de> |
---|---|
To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | pgsql: Deal with paths containing \ and spaces in basebackup_to_shell t |
Date: | 2022-07-18 18:45:33 |
Message-ID: | E1oDVkJ-0009cH-VZ@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Deal with paths containing \ and spaces in basebackup_to_shell tests
As $gzip is embedded in postgresql.conf \ needs to be escaped, otherwise guc.c
will take it as a string escape. Similarly, if "$gzip" contains spaces, the
prior incantation will fail. Both of these are common on windows.
Reviewed-by: Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>
Discussion: https://postgr.es/m/ce1b6eb3-5736-6f38-9775-b7020128b8d8@enterprisedb.com
Backpatch: 15-, where the test was added in 027fa0fd726
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/a91242b1bcb312d6f482a758a432a32bd375896e
Modified Files
--------------
contrib/basebackup_to_shell/t/001_basic.pl | 11 +++++++----
1 file changed, 7 insertions(+), 4 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Peter Eisentraut | 2022-07-18 19:08:23 | pgsql: Re-add SPICleanup for ABI compatibility in stable branch |
Previous Message | Tomas Vondra | 2022-07-18 17:26:21 | pgsql: Reinstate tests accidentally removed by e3fcca0d0d |