pgsql: Improve error reporting from validate_exec().

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Improve error reporting from validate_exec().
Date: 2022-07-12 19:37:51
Message-ID: E1oBLhe-002Tmx-63@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Improve error reporting from validate_exec().

validate_exec() didn't guarantee to set errno to something appropriate
after a failure, leading to callers not being able to print an on-point
message. Improve that.

Noted by Kyotaro Horiguchi, though this isn't exactly his proposal.

Discussion: https://postgr.es/m/20220615.131403.1791191615590453058.horikyota.ntt@gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/920072339f304a7da0b5de966117420c96ad78cb

Modified Files
--------------
src/bin/pg_upgrade/exec.c | 11 ++---------
src/common/exec.c | 16 ++++++++++++++--
2 files changed, 16 insertions(+), 11 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2022-07-12 20:30:52 pgsql: Invent qsort_interruptible().
Previous Message Tom Lane 2022-07-12 19:17:54 pgsql: Remove trailing newlines in pg_upgrade's message strings.