From: | John Naylor <john(dot)naylor(at)postgresql(dot)org> |
---|---|
To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | pgsql: Build de-escaped JSON strings in larger chunks during lexing |
Date: | 2022-07-11 04:15:20 |
Message-ID: | E1oAkpK-002DWJ-IK@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Build de-escaped JSON strings in larger chunks during lexing
During COPY BINARY with large JSONB blobs, it was found that half
the time was spent parsing JSON, with much of that spent in separate
appendStringInfoChar() calls for each input byte.
Add lookahead loop to json_lex_string() to allow batching multiple bytes
via appendBinaryStringInfo(). Also use this same logic when de-escaping
is not done, to avoid code duplication.
Report and proof of concept patch by Jelte Fennema, reworked by Andres
Freund and John Naylor
Discussion: https://www.postgresql.org/message-id/CAGECzQQuXbies_nKgSiYifZUjBk6nOf2%3DTSXqRjj2BhUh8CTeA%40mail.gmail.com
Discussion: https://www.postgresql.org/message-id/flat/PR3PR83MB0476F098CBCF68AF7A1CA89FF7B49(at)PR3PR83MB0476(dot)EURPRD83(dot)prod(dot)outlook(dot)com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/3838fa269c15706df2b85ce2d6af8aacd5611655
Modified Files
--------------
src/common/jsonapi.c | 58 +++++++++++++++++++++++++++++++++++-----------------
1 file changed, 39 insertions(+), 19 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Thomas Munro | 2022-07-11 04:46:46 | pgsql: Fix lock assertions in dshash.c. |
Previous Message | Michael Paquier | 2022-07-11 03:49:11 | Re: pgsql: Only allow returning string types or bytea from json_serialize |