pgsql: Improve two comments related to a boolean DefElem's value

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Improve two comments related to a boolean DefElem's value
Date: 2022-07-11 02:07:51
Message-ID: E1oAipx-002CRK-Kr@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Improve two comments related to a boolean DefElem's value

The original comments mentioned a "parameter" as something not defined
in a fast-exit path to assume a true status. This is rather confusing
as the parameter DefElem is defined, and the intention is to check if
its value is defined. This improves both comments to mention the value
assigned to the DefElem's value instead, so as future patches are able
to catch the tweak if this code pattern gets copied around more.

Author: Peter Smith
Discussion: https://postgr.es/m/CAHut+Pv0yWynWTmp4o34s0d98xVubys9fy=p0YXsZ5_sUcNnMw@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/8445f5a21d40b969673ca03918c74b4fbc882bf4

Modified Files
--------------
src/backend/commands/copy.c | 2 +-
src/backend/commands/define.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Michael Paquier 2022-07-11 02:32:38 pgsql: Improve error message with JSON_SERIALIZE()
Previous Message Michael Paquier 2022-07-11 01:57:16 pgsql: doc: Fix inconsistent quotes in some jsonb fields