pgsql: Don't fail on libpq-generated error reports in pg_amcheck.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Don't fail on libpq-generated error reports in pg_amcheck.
Date: 2022-06-06 15:27:07
Message-ID: E1nyEdH-00308s-3k@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Don't fail on libpq-generated error reports in pg_amcheck.

An error PGresult generated by libpq itself, such as a report of
connection loss, won't have broken-down error fields.
should_processing_continue() blithely assumed that
PG_DIAG_SEVERITY_NONLOCALIZED would always be present, and would
dump core if it wasn't.

Per grepping to see if 6d157e7cb's mistake was repeated elsewhere.

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/51da231597a9e414174cf621b219559e18269dc3

Modified Files
--------------
src/bin/pg_amcheck/pg_amcheck.c | 2 ++
1 file changed, 2 insertions(+)

Browse pgsql-committers by date

  From Date Subject
Next Message Stephen Frost 2022-06-06 18:52:03 Re: pgsql: Use pre-fetching for ANALYZE
Previous Message Tom Lane 2022-06-06 15:21:19 pgsql: Don't fail on libpq-generated error reports in ecpg_raise_backen