pgsql: Ignore heap rewrites for materialized views in logical replicati

From: Amit Kapila <akapila(at)postgresql(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Ignore heap rewrites for materialized views in logical replicati
Date: 2022-06-03 02:51:56
Message-ID: E1nwxPo-002RWD-Hh@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Ignore heap rewrites for materialized views in logical replication.

If you have a publication that specifies FOR ALL TABLES clause, a REFRESH
MATERIALIZED VIEW can break your setup with the following message

ERROR: logical replication target relation "public.pg_temp_NNN" does not exist

Commit 1a499c2520 introduces a heuristic to skip table writes that look
like they are from a heap rewrite for a FOR ALL TABLES publication.
However, it forgot to exclude materialized views (heap rewrites occur when
you execute REFRESH MATERIALIZED VIEW). Since materialized views are not
supported in logical decoding, it is appropriate to filter them too.

As explained in the commit 1a499c2520, a more robust solution was included
in version 11 (commit 325f2ec555), hence only version 10 is affected.

Reported-by: Euler Taveira
Author: Euler Taveira
Reviewed-by: Amit Kapila
Discussion: https://postgr.es/m/bc557ebe-92dc-4afa-b6bb-285a9eeaa614@www.fastmail.com

Branch
------
REL_10_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/37fd181d6dea9675181344ea9364ef6b66919aec

Modified Files
--------------
src/backend/replication/pgoutput/pgoutput.c | 4 +++-
src/test/subscription/t/006_rewrite.pl | 20 +++++++++++++++++++-
2 files changed, 22 insertions(+), 2 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Michael Paquier 2022-06-03 04:15:50 pgsql: Run tests of libpq on installcheck-world, checkprep and check-wo
Previous Message Andres Freund 2022-06-03 02:35:11 Re: pgsql: Use pre-fetching for ANALYZE