pgsql: shm_mq_sendv: Fix flushing bug when receiver not yet attached.

From: Robert Haas <rhaas(at)postgresql(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: shm_mq_sendv: Fix flushing bug when receiver not yet attached.
Date: 2022-05-31 12:53:21
Message-ID: E1nw1NB-0021xM-8k@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

shm_mq_sendv: Fix flushing bug when receiver not yet attached.

With the old logic, when the reciever had not yet attached, we would
never call shm_mq_inc_bytes_written(), even if force_flush = true
was specified. That could result in a situation where data that the
sender believes it has sent is never received.

Along the way, remove a useless function prototype for a nonexistent
function from shm_mq.h.

Commit 46846433a03dff4f2e08c8a161e54a842da360d6 introduced these
problems.

Pavan Deolasee, with a few changes by me.

Discussion: https://postgr.es/m/CABOikdPkwtLLCTnzzmpSMXo3QZa2yXq0J7Q61ssdLFAJYrOVvQ@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/f5bfba5413f51b4fa0a7b0dc879d39ae6881d8be

Modified Files
--------------
src/backend/storage/ipc/shm_mq.c | 11 +++++------
src/include/storage/shm_mq.h | 1 -
2 files changed, 5 insertions(+), 7 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2022-05-31 16:18:57 pgsql: Doc: fix mention of pg_dump's minimum supported server version.
Previous Message Amit Kapila 2022-05-31 09:11:25 pgsql: Fix typo in hash README.