From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | pgsql: Avoid overflow hazard when clamping group counts to "long int". |
Date: | 2022-05-21 17:14:03 |
Message-ID: | E1nsSfy-000T3n-Us@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Avoid overflow hazard when clamping group counts to "long int".
Several places in the planner tried to clamp a double value to fit
in a "long" by doing
(long) Min(x, (double) LONG_MAX);
This is subtly incorrect, because it casts LONG_MAX to double and
potentially back again. If long is 64 bits then the double value
is inexact, and the platform might round it up to LONG_MAX+1
resulting in an overflow and an undesirably negative output.
While it's not hard to rewrite the expression into a safe form,
let's put it into a common function to reduce the risk of someone
doing it wrong in future.
In principle this is a bug fix, but since the problem could only
manifest with group count estimates exceeding 2^63, it seems unlikely
that anyone has actually hit this or will do so anytime soon. We're
fixing it mainly to satisfy fuzzer-type tools. That being the case,
a HEAD-only fix seems sufficient.
Andrey Lepikhov
Discussion: https://postgr.es/m/ebbc2efb-7ef9-bf2f-1ada-d6ec48f70e58@postgrespro.ru
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/a916cb9d5a89804998dd4e7fd7bbb27cb5a7abc8
Modified Files
--------------
src/backend/executor/nodeSubplan.c | 4 ++--
src/backend/optimizer/path/costsize.c | 27 +++++++++++++++++++++++++++
src/backend/optimizer/plan/createplan.c | 7 +++----
src/include/optimizer/optimizer.h | 1 +
4 files changed, 33 insertions(+), 6 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2022-05-21 17:26:22 | pgsql: Remove unused-and-misspelled function extern declaration. |
Previous Message | Michael Paquier | 2022-05-21 10:07:22 | pgsql: doc: Mention pg_read_all_stats in description of track_activitie |