pgsql: Fix slow animal timeouts in 032_relfilenode_reuse.pl.

From: Thomas Munro <tmunro(at)postgresql(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Fix slow animal timeouts in 032_relfilenode_reuse.pl.
Date: 2022-05-14 00:06:41
Message-ID: E1npfIu-000ahY-TN@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Fix slow animal timeouts in 032_relfilenode_reuse.pl.

Per BF animal chipmunk: CREATE DATABASE could apparently fail due to an
AV process being in the template database and not quitting fast enough
for the 5 second timeout in CountOtherDBBackends(). The test script had
autovacuum_naptime=1s to encourage more activity and opening of fds, but
that wasn't strictly necessary for this test. Take it out.

Per BF animal skink: there was a 300s timeout for all tests in the
script, but apparently that was not enough under valgrind. Let's use
the standard timeout $PostgreSQL::Test::Utils::timeout_default, but
restart it for each query we run.

Reviewed-by: Robert Haas <robertmhaas(at)gmail(dot)com>
Discussion: https://postgr.es/m/CA%2BhUKGKa8HNJaA24gqiiFoGy0ysndeVoJsHvX_q1-DVLFaGAmw%40mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/93759c665d482b5bf76ca22c9cac91e713e9386e

Modified Files
--------------
src/test/recovery/t/032_relfilenode_reuse.pl | 14 ++++++++------
1 file changed, 8 insertions(+), 6 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Alvaro Herrera 2022-05-14 07:06:49 pgsql: Add link to initdb in pg_hba.conf docs
Previous Message Michael Paquier 2022-05-13 23:28:33 pgsql: Fix comment in pg_proc.c