pgsql: set_deparse_plan: Reuse variable to appease Coverity

From: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: set_deparse_plan: Reuse variable to appease Coverity
Date: 2022-04-20 11:44:36
Message-ID: E1nh8lA-000GCY-BL@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

set_deparse_plan: Reuse variable to appease Coverity

Coverity complains that dpns->outer_plan is deferenced (to obtain
->targetlist) when possibly NULL. We can avoid this by using
dpns->outer_tlist instead, which was already obtained a few lines up.

The fact that we end up with
dpns->inner_tlist = dpns->outer_tlist
is a bit suspicious-looking and maybe worthy of more investigation, but
I'll leave that for another day.

Reviewed-by: Michaël Paquier <michael(at)paquier(dot)xyz>
Discussion: https://postgr.es/m/202204191345.qerjy3kxi3eb@alvherre.pgsql

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/e70813fbc4aaca35ec012d5a426706bd54e4acab

Modified Files
--------------
src/backend/utils/adt/ruleutils.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Peter Eisentraut 2022-04-20 14:17:50 pgsql: Fix incorrect format placeholders
Previous Message Alvaro Herrera 2022-04-20 09:26:57 pgsql: Move ModifyTableContext->lockmode to UpdateContext