pgsql: Track I/O timing for temporary file blocks in EXPLAIN (BUFFERS)

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Track I/O timing for temporary file blocks in EXPLAIN (BUFFERS)
Date: 2022-04-08 02:33:37
Message-ID: E1nceRM-000pI8-Q3@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Track I/O timing for temporary file blocks in EXPLAIN (BUFFERS)

Previously, the output of EXPLAIN (BUFFERS) option showed only the I/O
timing spent reading and writing shared and local buffers. This commit
adds on top of that the I/O timing for temporary buffers in the output
of EXPLAIN (for spilled external sorts, hashes, materialization. etc).
This can be helpful for users in cases where the I/O related to
temporary buffers is the bottleneck.

Like its cousin, this information is available only when track_io_timing
is enabled. Playing the patch, this is showing an extra overhead of up
to 1% even when using gettimeofday() as implementation for interval
timings, which is slightly within the usual range noise still that's
measurable.

Author: Masahiko Sawada
Reviewed-by: Georgios Kokolatos, Melanie Plageman, Julien Rouhaud,
Ranier Vilela
Discussion: https://postgr.es/m/CAD21AoAJgotTeP83p6HiAGDhs_9Fw9pZ2J=_tYTsiO5Ob-V5GQ@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/efb0ef909f605817da6b77c1f3fef0a24457ec16

Modified Files
--------------
doc/src/sgml/ref/explain.sgml | 13 ++--
src/backend/commands/explain.c | 42 ++++++++++---
src/backend/executor/instrument.c | 6 ++
src/backend/storage/file/buffile.c | 29 ++++++++-
src/include/executor/instrument.h | 6 +-
src/test/regress/expected/explain.out | 112 +++++++++++++++++++---------------
src/test/regress/sql/explain.sql | 7 ++-
7 files changed, 147 insertions(+), 68 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Andrew Dunstan 2022-04-08 03:46:30 pgsql: Documentation for SQL/JSON features
Previous Message Robert Haas 2022-04-08 02:19:35 Re: API stability [was: pgsql: Fix possible recovery trouble if TRUNCATE overlaps a checkpoint.]